Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs filterwarnings snippet #10671

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 22, 2021

What does this PR do?

Fixes part of #10644

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@carmocca carmocca added the docs Documentation related label Nov 22, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 22, 2021
@carmocca carmocca requested a review from awaelchli as a code owner November 22, 2021 13:00
@carmocca carmocca self-assigned this Nov 22, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) November 22, 2021 14:43
@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 48cb38a into master Nov 22, 2021
@carmocca carmocca deleted the docs/filterwarnings-num-workers branch November 22, 2021 14:52
rohitgr7 pushed a commit that referenced this pull request Nov 22, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants