-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LiteDataLoader code improvements and docs #10625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! This code was added for people not using a DataLoader
In order to provide a seamless experience with all accelerators and strategies, we currently assume in both Lightning and Lite only DataLoaders. |
AFAIK this is not true for Lightning, where we explicitly have type checks against the data loader when replacing samplers etc. to make sure it also works with raw iterables (just not all features then) |
This claim has been made in the past but where do we see that in our tests, docs and examples? I am failing to create an example based on our boring model, as it will just throw an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Adrian!
Would you mind also addressing the open reviews in #10279 ?
Co-authored-by: Carlos Mocholí <[email protected]>
7fb2747
to
b9bb5c3
Compare
for more information, see https://pre-commit.ci
Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Part of #10297 (follow-up to #10279)
Related: #10329
Updates docs, fixes typing (a DataLoader is not an iterator).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @justusschock @awaelchli @akihironitta @ninginthecloud @carmocca