Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lite: Don't pop value if they don't exist #10613

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Lite: Don't pop value if they don't exist #10613

merged 4 commits into from
Nov 19, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 18, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@tchaton tchaton added bug Something isn't working fabric lightning.fabric.Fabric labels Nov 18, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 18, 2021
@tchaton tchaton self-assigned this Nov 18, 2021
@tchaton tchaton requested a review from awaelchli as a code owner November 18, 2021 16:31
@tchaton tchaton requested a review from carmocca as a code owner November 18, 2021 16:31
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

4 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

awaelchli
awaelchli reviewed Nov 18, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 18, 2021
@tchaton @awaelchli
Update CHANGELOG.md
d0e962c 
Co-authored-by: Adrian Wälchli <[email protected]>
@tchaton tchaton enabled auto-merge (squash) November 18, 2021 17:29
@mergify mergify bot removed the has conflicts label Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #10613 (82dfaf6) into master (c09c9c7) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10613    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         178      178            
  Lines       16286    16286            
========================================
- Hits        14941    14324   -617     
- Misses       1345     1962   +617

@tchaton tchaton merged commit 94390ab into master Nov 19, 2021
@tchaton tchaton deleted the fix_lite_2 branch November 19, 2021 14:04
rohitgr7 pushed a commit that referenced this pull request Nov 20, 2021
@tchaton @rohitgr7
Lite: Don't pop value if they don't exist (#10613)
db1b960
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@tchaton @Raalsky
Lite: Don't pop value if they don't exist (Lightning-AI#10613)
a172315
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
@tchaton @awaelchli
Lite: Don't pop value if they don't exist (#10613)
5c404de
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@tchaton @lexierule
Lite: Don't pop value if they don't exist (#10613)
302c611
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
5 participants
@tchaton @ananthsub @awaelchli @carmocca @kaushikb11