-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added boring model as a ipynb so it can be updated #10521
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
|
We should also drop torch vision, Mnist import. Let's keep it minimal. |
I'll change the imports again and add the colab link to the github issue template then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For any reviewers, you can check the Notebook with this link:
https://colab.research.google.com/github/jiwidi/pytorch-lightning/blob/master/pl_examples/bug_report/The_BoringModel.ipynb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Much cleaner !
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
What does this PR do?
Fixes #10490
This PR adds the boring model notebook along with a needed fix on an outdated import. The purpose of this PR is so the google colab linking to the boring model aims at the ipynb version on master, allowing the PL team to update and mantain the notebook within github.
If this PR moves forward, the default issue link should be updated.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Yes