-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation for every_n_epochs parameter of ModelCheckpoint #10421
Merged
justusschock
merged 2 commits into
Lightning-AI:master
from
adamreeve:checkpoint_doc_fix
Nov 19, 2021
Merged
Fix documentation for every_n_epochs parameter of ModelCheckpoint #10421
justusschock
merged 2 commits into
Lightning-AI:master
from
adamreeve:checkpoint_doc_fix
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
requested review from
Borda,
carmocca,
kaushikb11,
tchaton and
williamFalcon
as code owners
November 8, 2021 20:54
carmocca
approved these changes
Nov 9, 2021
justusschock
approved these changes
Nov 9, 2021
Borda
approved these changes
Nov 9, 2021
ananthsub
approved these changes
Nov 10, 2021
tchaton
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
Do I need to do anything to get this merged? Looks like it's blocked on some test failures that look unrelated to this change, plus not having a linked issue, although from the PR template this shouldn't be required for a docs change. |
rohitgr7
pushed a commit
that referenced
this pull request
Nov 22, 2021
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
awaelchli
pushed a commit
that referenced
this pull request
Nov 24, 2021
lexierule
pushed a commit
that referenced
this pull request
Nov 24, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes documentation on the
every_n_epochs
parameter inModelCheckpoint
. This incorrectly states that leaving the value as the default ofNone
means that checkpoints are not saved.Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃