-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exceptions when torch distributed is not available #10418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
Borda,
carmocca,
SeanNaren and
tchaton
as code owners
November 8, 2021 18:36
Codecov Report
@@ Coverage Diff @@
## master #10418 +/- ##
=======================================
- Coverage 89% 89% -0%
=======================================
Files 181 181
Lines 16386 16319 -67
=======================================
- Hits 14523 14455 -68
- Misses 1863 1864 +1 |
ananthsub
reviewed
Nov 8, 2021
ananthsub
changed the title
Raise exceptions when torch distributed is not avalible
Raise exceptions when torch distributed is not available
Nov 8, 2021
ananthsub
approved these changes
Nov 8, 2021
carmocca
approved these changes
Nov 9, 2021
@four4fish could you update the changelog as well? |
four4fish
requested review from
awaelchli,
justusschock,
kaushikb11,
rohitgr7 and
williamFalcon
as code owners
November 9, 2021 01:06
justusschock
approved these changes
Nov 9, 2021
Co-authored-by: ananthsub <[email protected]>
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
…I#10418) * Raise exceptions when torch distributed is not avalible * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids init_dist_connection failing silently
If torch.distributed is not available, the process_group cannot be created. Later, the runtime will fail when wrapping model or after training steps (when call distributed_c10d). So we should fail faster at
init_dist_connection
steppartially fixes #10348
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃