-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly Patch Release v1.5.1 #10333
Weekly Patch Release v1.5.1 #10333
Conversation
2baa1e4
to
ca3c6a4
Compare
Some fixes that could potentially be included today: |
d3725c9
to
5df2eb7
Compare
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
* Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed
* Don't store csv.Dictwriter in ExperimentWriter * Add test for pickle after .save() * Add entry in changelog
* disable step logging in epoch hooks * chlog * Apply suggestions from code review * chlog
3ba3346
to
a813be8
Compare
Co-authored-by: Kaushik Bokka <[email protected]>
* fix * less code * add test case * add test cases * update input * add test cases * add type hint * add changelog note Co-authored-by: Kaushik B <[email protected]>
…#10432) Co-authored-by: Thomas Chaton <[email protected]>
…#10434) Co-authored-by: Thomas Chaton <[email protected]>
2c7202f
to
b427fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to update the description once finalized :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Chapter begins! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just not sure if we really want to update all CI do newer versions of Python, I would probably rather stay conservative, and as we have not updated it before v1.5 then do not update bugfix branch either...
It's fine to keep, no versions were added or removed, the jobs were just reorganized. |
What does this PR do?
Contains all bugfixes to be released next week. As bugfixes get merged to master, they will get cherry-picked into this branch by the individual author (core) or on-caller.
For staff/core: The new release guide is here.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)