Move device parser utility function #10230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
ananthsub
reviewed
Oct 28, 2021
four4fish
reviewed
Oct 29, 2021
awaelchli
force-pushed
the
lightning-lite/device-parser
branch
from
de42e8b to
49697ac
Compare
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
carmocca
approved these changes
Oct 30, 2021
kaushikb11
suggested changes
Nov 4, 2021
There was a problem hiding this comment.
@awaelchli We had discussed to keep the Trainer method, and use the utility function inside it
for more information, see https://pre-commit.ci
|
Changed |
justusschock
approved these changes
Nov 4, 2021
kaushikb11
approved these changes
Nov 4, 2021
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
* move parser function to utils * fix types * keep static method * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses comment #9987 (comment)
The Trainer and Lite share a device parsing logic. We can move this static method out of Trainer and place it where the rest of the device parsing lives. This way, Lite does not need to import the Lightning Trainer.
Before submitting
Changelog not needed, the function was protected/internal
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)