Fix endpoint information tab not showing up in AutoScaler UI (#16128)

* . * why * Revert "why" This reverts commit 375d3e8. * tried api access with fixed values * Revert "tried api access with fixed values" This reverts commit f1720f6. * Fix typo 🎉 * update chglog * revert removing lines in chlog * update chglog Co-authored-by: Akihiro Nitta <[email protected]> (cherry picked from commit 7b275bc)
Lightning-AI · Dec 20, 2022 · 0800063 · 0800063
1 parent 6697832
commit 0800063
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/lightning_app/CHANGELOG.md b/src/lightning_app/CHANGELOG.md
@@ -66,6 +66,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Fixed Http Queue sleeping for 1 sec by default if no delta were found ([#16114](https://github.com/Lightning-AI/lightning/pull/16114))
 
 
+- Fixed the endpoint info tab not showing up in `AutoScaler` UI ([#16128](https://github.com/Lightning-AI/lightning/pull/16128))
+
+
 ## [1.8.5] - 2022-12-15
 
 ### Added

diff --git a/src/lightning_app/components/serve/auto_scaler.py b/src/lightning_app/components/serve/auto_scaler.py
@@ -469,8 +469,8 @@ def _get_sample_dict_from_datatype(datatype: Any) -> dict:
             # not a pydantic model
             raise TypeError(f"datatype must be a pydantic model, for the UI to be generated. but got {datatype}")
 
-        if hasattr(datatype, "_get_sample_data"):
-            return datatype._get_sample_data()
+        if hasattr(datatype, "get_sample_data"):
+            return datatype.get_sample_data()
 
         datatype_props = datatype.schema()["properties"]
         out: Dict[str, Any] = {}
@@ -774,7 +774,7 @@ def autoscale(self) -> None:
 
     def configure_layout(self):
         tabs = [
-            {"name": "Endpoint Info", "content": f"{self.load_balancer}/endpoint-info"},
+            {"name": "Endpoint Info", "content": f"{self.load_balancer.url}/endpoint-info"},
             {"name": "Swagger", "content": self.load_balancer.url},
         ]
         return tabs