Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue that precision is always "32-true". #1802

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

jianpingw
Copy link
Contributor

The precision is always "32-true" regardless of the value passed from the parameter, which is incorrect. This PR removes the erroneous extra line:

precision = "32-true"

Copy link
Collaborator

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that was quite a bad typo. Thanks a lot for addressing that!

@rasbt rasbt merged commit 47ce3bf into Lightning-AI:main Oct 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants