Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add support for numpy datatypes in tokensloader #401

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Oct 27, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #400.

  • Feature: Add support for numpy datatypes in TokensLoader

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy added the enhancement New feature or request label Oct 27, 2024
@bhimrazy bhimrazy self-assigned this Oct 27, 2024
@bhimrazy bhimrazy marked this pull request as draft October 27, 2024 19:33
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (73f767f) to head (69719df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #401   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5045   5052    +7     
===================================
+ Hits       3954   3960    +6     
- Misses     1091   1092    +1     

src/litdata/streaming/item_loader.py Outdated Show resolved Hide resolved
@bhimrazy bhimrazy marked this pull request as ready for review November 5, 2024 07:28
@bhimrazy bhimrazy requested a review from tchaton November 5, 2024 07:30
Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@tchaton tchaton merged commit a247307 into Lightning-AI:main Nov 5, 2024
36 checks passed
@bhimrazy bhimrazy deleted the feat/add-support-for-numpy-datatypes-in-tokensloader branch November 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for numpy datatypes in TokensLoader
2 participants