CONTRIBUTING.md for LitData #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
===================================
Coverage 78% 78%
===================================
Files 34 34
Lines 5044 5042 -2
===================================
Hits 3948 3948
+ Misses 1096 1094 -2 |
Sure @deependujha. Thanks for drafting a PR. |
tchaton
approved these changes
Oct 8, 2024
bhimrazy
requested changes
Oct 9, 2024
deependujha
commented
Oct 14, 2024
deependujha
commented
Oct 14, 2024
|
For now, this PR is ready for review. |
The original PR was merged before I could remove the loop (I was not active). |
|
Nice @deependujha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #354
I've just copy-pasted
CONTRIBUTING.mdfrom pytorch-lightning repository. No modifications done yet. Let's Work together on this and adapt it for LitData.Aim is to make it simple and powerful enough for beginners to get started with contributing to LitData.
cc:
@bhimrazy
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃