Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feat: Using fsspec to download files" #380

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Sep 19, 2024

Reverts #348

@deependujha
Copy link
Collaborator

hi, is there any issue?

@tchaton
Copy link
Collaborator Author

tchaton commented Sep 19, 2024

hi, is there any issue?

Yes, streaming hangs in Studio using a dataset and it blocking our platform CI. I need to revert, release and we can investigate later on what's up.

@deependujha
Copy link
Collaborator

okay, sure.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 66.52361% with 78 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (08d6104) to head (d7682b9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #380   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        33     34    +1     
  Lines      4987   5012   +25     
===================================
+ Hits       3892   3930   +38     
+ Misses     1095   1082   -13     

@tchaton tchaton merged commit c6e0e66 into main Sep 19, 2024
26 of 28 checks passed
@tchaton tchaton deleted the revert-348-feat/using-fsspec-to-download-files branch September 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants