-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Prevent multiple processes from copying the same file when using… #353
Conversation
… the file: protocol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
Thank you for the PR, @dallmann-uniwue. It appears that the errors are primarily due to the change in the total count caused by the addition of lock files. |
@bhimrazy I have taken a shot at fixing the tests. Rather then just adjusting the expected file counts, I opted to filter out the lock files. What do you think? |
Thank you @dallmann-uniwue , Looks great. 😊 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
===================================
Coverage 78% 78%
===================================
Files 34 34
Lines 5008 5016 +8
===================================
+ Hits 3922 3929 +7
- Misses 1086 1087 +1 |
You are welcome @bhimrazy! Thank you for working on this, litdata is making my life a lot easier! |
… the file: protocol
Before submitting
What does this PR do?
Fixes #351 by guarding copying the
index.json
to the cache directory with a FileLock when using thefile:
protocol.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Sure! 🙃