Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/minor fixes #329

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Ref/minor fixes #329

merged 2 commits into from
Aug 11, 2024

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Aug 11, 2024

What does this PR do?

Fixes.

  • Fixes typo with gcp prefix
  • Refactor cloud prefix handling in resolver.py

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy self-assigned this Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@95782ab). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #329   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     34           
  Lines           ?   4976           
  Branches        ?      0           
=====================================
  Hits            ?   3877           
  Misses          ?   1099           
  Partials        ?      0           

@tchaton tchaton merged commit 9791488 into Lightning-AI:main Aug 11, 2024
28 checks passed
@bhimrazy bhimrazy deleted the ref/minor-fixes branch August 12, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants