Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy unit test max download #325

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

animan42
Copy link
Contributor

Before submitting
  • [✅] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • [✅] Did you read the contributor guideline, Pull Request section?
  • [✅] Did you make sure to update the docs?
  • [✅] Did you write any new necessary tests?

What does this PR do?

Adds unit test for #323

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ae383ea). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #325   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     34           
  Lines           ?   4975           
  Branches        ?      0           
=====================================
  Hits            ?   3876           
  Misses          ?   1099           
  Partials        ?      0           

@tchaton tchaton merged commit a406715 into Lightning-AI:main Aug 10, 2024
28 checks passed
@tchaton
Copy link
Collaborator

tchaton commented Aug 10, 2024

Thanks @animan42 for your contribution ;) And making another PR for adding the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants