Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve num_workers when the user provides 0 #173

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Resolve num_workers when the user provides 0 #173

merged 2 commits into from
Jun 15, 2024

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Jun 15, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

We need to have at least 1 worker for the optimize and map operators. So 0 would be resolved as the number of processes.

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton marked this pull request as ready for review June 15, 2024 06:36
@tchaton tchaton requested a review from awaelchli as a code owner June 15, 2024 06:36
@tchaton tchaton merged commit b51b597 into main Jun 15, 2024
31 of 32 checks passed
@tchaton tchaton deleted the fix_num_workers branch June 15, 2024 06:54
@tchaton tchaton restored the fix_num_workers branch June 15, 2024 16:06
@bhimrazy bhimrazy deleted the fix_num_workers branch November 5, 2024 09:09
@bhimrazy bhimrazy restored the fix_num_workers branch November 5, 2024 09:10
@bhimrazy bhimrazy deleted the fix_num_workers branch November 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant