[WIP] Draft checkpoint interpret call #1275
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
IvanYashchuk
reviewed
Oct 9, 2024
Comment on lines
+686
to
+688
| @wraps(trace_of_checkpoint.python_callable()) | ||
| def core_of_forward(f, *args, **kwargs): | ||
| return thunder.core.trace_interpreter.interpret_trace(trace_of_checkpoint, f, *args, **kwargs) |
There was a problem hiding this comment.
Can this core_of_forward (but without f argument) be sent as the function-to-be-checkpointed to thunder.torch.checkpoint function from #1127? Then the rest of the custom registration could probably be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
use _interpret_call to trace checkpoint