Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding metrics with torch #72

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

adding metrics with torch #72

wants to merge 27 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 5, 2022

Before submitting

  • Was this discussed/approved via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file?
  • Did you set runtimes in config for GitHub action integration?
  • Did you add your config to CI in Azure pipeline (only projects with 100+ GitHub stars)?
  • Are all integration tests passing?

What does this PR do? [optional]

Adding compatibility with future pyTorch

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Merging #72 (707c075) into main (2c7b4d0) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files 
@@        Coverage Diff         @@
##           main   #72   +/-   ##
==================================
  Coverage    78%   78%           
==================================
  Files         2     2           
  Lines       256   257    +1     
==================================
+ Hits        200   201    +1     
  Misses       56    56

@Borda Borda changed the title add metrics with torch adding metrics with torch Dec 5, 2022
@Borda Borda self-assigned this Dec 6, 2022
@Borda Borda mentioned this pull request Dec 6, 2022
Merged
5 tasks
@Borda Borda marked this pull request as draft December 6, 2022 15:12
@Borda Borda marked this pull request as ready for review December 6, 2022 18:17
akihironitta
akihironitta approved these changes Jan 16, 2023
View reviewed changes
.github/workflows/ci_compatible.yml Outdated Show resolved Hide resolved
_actions/assistant.py Outdated Show resolved Hide resolved
configs/Lightning-AI/metrics_torch-develop.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@akihironitta akihironitta akihironitta approved these changes

@justusschock justusschock justusschock approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Borda Borda

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @justusschock @akihironitta @SkafteNicki