-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NN Template #44
base: main
Are you sure you want to change the base?
Add NN Template #44
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==================================
Coverage 80% 80%
==================================
Files 2 2
Lines 252 252
==================================
Hits 201 201
Misses 51 51 |
Hello, Is there anything we can improve upstream to get this integration smoother? Are there any blockers? Thanks, |
We are just finishing 2.1 release, and this project just about to get some cleaning and extension for other HW, will be proceeding next week, and apology for the delay 😿 |
Not at all! 😄 |
Before submitting
runtimes
in config for GitHub action integration?What does this PR do? [optional]
Add support for nn-template.
Did you have fun?
Always 🙃
Missing
Cookiecutter integration
The nn-template uses cookiecutter to generate a parametrized project from a template.
Thus it is not enough to clone/checkout a repository to obtain a working project.
In our CI we are using the following to: (1) generate the project with cookiecutter and (2) by-pass the interactive setup (with the hacky echo command)
Dependencies
This project uses a combination of conda and pip, most of the dependencies are specified in the
setup.cfg
file.To configure an environment, thus, there are two options (after changing the working directory to the cookiecutter-generated project):
conda
:conda env create -f env.yaml
pip install ".[dev]"
I am not sure which is the best option here, if we want to test the development setup I think the 1. would be more adequate.
Complete config
Part of the file is still borrowed from the template config, e.g. the dependencies, runtimes and
before_test
(p.s. the template file indicated in the README asconfigs/template.yaml
does not exists anymore).These are the main challenges I see at the moment. Once the environment is active to run the tests (and maybe the pre-commits) it is enough to:
Please feel free to contribute to this PR if you have any spare time! Otherwise I will try to understand better how to solve these problems in the Lightning's ecosystem CI (not in the immediate future though!).
@Borda @rasbt @Flegyas