Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UUIDs in request payloads #86

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Add support for UUIDs in request payloads #86

merged 2 commits into from
Sep 19, 2023

Conversation

samamorgan
Copy link
Collaborator

Resolves #77

@samamorgan samamorgan changed the base branch from main to develop September 19, 2023 20:04
@samamorgan samamorgan requested a review from gone September 19, 2023 20:06
gone
gone approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@gone gone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I think my approach with the dates would be to use time-machine https://github.com/adamchainz/time-machine#pytest-plugin since that can mock the timezones too

@samamorgan samamorgan merged commit ab9bfe2 into develop Sep 19, 2023
@samamorgan samamorgan deleted the feature/uuid-parsing branch September 19, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gone gone gone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for UUIDs in request payloads
2 participants
@samamorgan @gone