pkg/lb/lbgrpc/client.go: createsnapshtot err #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightbits api will return Unavaialble err instead of failprecondition if we attempt to create a new snapshot whle previous create snapshot request was still running. this commit doesnt change the logic, but will ensure that we continue to get same logs regardless of the error. Signed-off-by: ronen <[email protected]>
muliby-lb
reviewed
Jan 1, 2024
| @@ -1263,14 +1263,24 @@ func (c *Client) CreateSnapshot( | |||
| return nil, status.Errorf(codes.Internal, | |||
| "failed to create snapshot '%s' on LB: %s", name, st.Message()) | |||
| case codes.FailedPrecondition: | |||
| // most likely source volume is being updated, tell | |||
| // most likely old snapshot still creating (older Lightbits releases), tell | |||
There was a problem hiding this comment.
most likely old snapshot is still being created (this blocked creating new snapshots in older Lightbits releases)
| // upper layers to retry the whole thing and | ||
| // hope the logic above will weed out the bad states so | ||
| // we don't end up in an infinite loop: | ||
| c.log.Debugf("create snapshot refused by LB on failed "+ | ||
| "precondition: %s", st.Message()) | ||
| return nil, status.Errorf(codes.Unavailable, | ||
| "create snapshot (%s) transiently failed", name) | ||
| case codes.Unavailable: | ||
| // most likely old snapshot still creating (newer Lightbits releases), |
| // upper layers to retry the whole thing and | ||
| // hope the logic above will weed out the bad states so | ||
| // we don't end up in an infinite loop: | ||
| c.log.Debugf("create snapshot refused by LB on failed "+ |
There was a problem hiding this comment.
create snapshot operation returned <...>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightbits api will return Unavaialble err instead of failprecondition if we attempt to create a new snapshot whle previous create snapshot request was still running.
this commit doesnt change the logic, but will ensure that we continue to get same logs regardless of the error.