完成 week6 作業 #8
Merged
完成 week6 作業 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChihYang41
reviewed
Aug 31, 2020
| <picture> | ||
| <source srcset="src/img/p-1.webp" type="image/webp" /> | ||
| <source srcset="src/img/p-1.png" type="image/png" /> | ||
| <img src="./src/img/[email protected]" alt="蘿莉控遺像" /> |
| </head> | ||
| ``` | ||
|
|
||
| 疑問：聽聞 `<a>` 如果是 `target="_blank"` 要加上 `rel=noopener noreferrer` 來防止惡意導向，不知道這個屬性是不是可以直接加在 `<base>` 上... |
There was a problem hiding this comment.
查了一下資料，從 MDN 看來目前是沒有這個 attribute，不過的確是有看到討論 rel=noopener for form and base elements
There was a problem hiding this comment.
看起來好像開放用在<base>上會增加混亂，需要的時候在使用於<a>就好。
|
|
||
| #### ✅ P2 你熟悉 CSS selector，可以輕鬆選到想選到的元素 | ||
|
|
||
| 有越來越輕鬆的感覺沒錯 |
|
好猛的作業啊啊啊，朝聖 🙇♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這週作業完成後，對自己 CSS 能力有自信多了！擺脫以前想做到，但都要蘑菇非常久才做出來，而且還不一定知道自己在幹什麼的狀況。基本的選擇器、屬性語法可以自然打出，跟以前相比真的少了很多查閱的煩躁時間，謝謝自己的努力 😂
這次嘗試了一些東西：
aria-labelledby屬性，替被我客製的表單輸入框維持 Accessibility 分數backgraound-position: fixed和直接使用<img>之間游移，最後使用<img>因為可以用<picture>指定載入的圖片格式或大小，在手機上也有視差效果。咬一口廚房預覽
新拖延運動預覽
謝謝 Huli 和助教的批改！