Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metadata access #89

Merged
merged 16 commits into from
Jul 18, 2024
Merged

Feature/metadata access #89

merged 16 commits into from
Jul 18, 2024

Conversation

aneuwald-ctw
Copy link
Contributor

User-Facing Changes
Users will now have the ability to read the metadata of MCAP files through the ExtensionContext. This enables automation of tasks according to their specific use cases.

Description
To summarize the changes, when an MCAP file is read (inside an IterableSource), its metadata will be stored within the Player, that is created when a file is being read. The Player is then stored inside the MessagePipelineContext, which is accessible via the useMessagePipeline hook in the PanelExtensionAdapter component. In this component, the context: ExtensionContext will be created, the metadata will be added to it, and then passed on to the extensions.

The metadata object is typed as readonly and deeply frozen to ensure immutability both at compile time and runtime. The original format of the metadata in MCAP files is a Map<string, string>, which will be transformed into a plain object. This transformation makes it easier to freeze the object and enhances performance since V8 handles plain objects more efficiently.

The metadata is accessible through a variable (context.metadata), but this variable is managed by the getMetadata function, which always returns a reference to the metadata object. This approach prevents the creation of unnecessary copies, re-renders and helps avoid Out of Memory (OOM) issues.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • The release version was updated on package.json files

aneuwald-ctw and others added 14 commits July 15, 2024 14:19
Bumps the npm_and_yarn group with 1 update in the /desktop directory:
[electron](https://github.com/electron/electron).
Bumps the npm_and_yarn group with 1 update in the /packages/studio-base
directory:
[sanitize-html](https://github.com/apostrophecms/sanitize-html).
Bumps the npm_and_yarn group with 1 update in the
/packages/studio-desktop directory:
[electron](https://github.com/electron/electron).

Updates `electron` from 25.5.0 to 25.8.4
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/electron/electron/commit/415301c477b600502cf264e93318dda551288829"><code>415301c</code></a>
chore: cherry-pick 3fbd1dca6a4d from libvpx (<a
href="https://redirect.github.com/electron/electron/issues/40024">#40024</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/b4742f9f919093ce870aaca166096072e7aaf56a"><code>b4742f9</code></a>
feat: enable dark mode on GTK UIs (<a
href="https://redirect.github.com/electron/electron/issues/40009">#40009</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/5868f9ac5eeb73ccd7ff36ff8733e03d5afd1e58"><code>5868f9a</code></a>
build: fix with <code>enable_pdf_viewer = false</code> (<a
href="https://redirect.github.com/electron/electron/issues/40000">#40000</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/6e675c831e758305b20217cc99601a20a429d02d"><code>6e675c8</code></a>
chore: add deprecated <code>app.runningUnderRosettaTranslation</code> to
breaking-change...</li>
<li><a
href="https://github.com/electron/electron/commit/66432ed9fcfabea081f14b809bd398daad1db685"><code>66432ed</code></a>
fix: use generic capturer to list both screens and windows when possible
(<a
href="https://redirect.github.com/electron/electron/issues/39">#39</a>...</li>
<li><a
href="https://github.com/electron/electron/commit/0ed48378c2c5950c55b2084c3b750b9f43d6f6a4"><code>0ed4837</code></a>
chore: cherry-pick tls shutdown crash fix from upstream (<a
href="https://redirect.github.com/electron/electron/issues/39945">#39945</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/42b4744740fec97f025019cac7f9abc59bd12ac8"><code>42b4744</code></a>
docs: add a more detailed explanation to cookies.flushStore() (<a
href="https://redirect.github.com/electron/electron/issues/39905">#39905</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/04e85b4eda93bacad55d7828c7f91c9a65e3d678"><code>04e85b4</code></a>
ci: fix linux builds of forks (<a
href="https://redirect.github.com/electron/electron/issues/39941">#39941</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/e42169b7e4e67cd4bf0da689c54082d7c9af29a3"><code>e42169b</code></a>
fix: <code>app.runningUnderARM64Translation()</code> always returning
true on Windows AR...</li>
<li><a
href="https://github.com/electron/electron/commit/67b2739f44ce98aad493170fecc696f76dc12de1"><code>67b2739</code></a>
chore: cherry-pick 1 changes from Release-0-M117 (<a
href="https://redirect.github.com/electron/electron/issues/39919">#39919</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/electron/electron/compare/v25.5.0...v25.8.4">compare
view</a></li>
</ul>
</details>
<br />

Updates `sanitize-html` from 2.11.0 to 2.12.1
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md">sanitize-html's
changelog</a>.</em></p>
<blockquote>
<h2>2.12.1 (2024-02-22)</h2>
<ul>
<li>Do not parse sourcemaps in <code>post-css</code>. This fixes a
vulnerability in which information about the existence or non-existence
of files on a server could be disclosed via properly crafted HTML input
when the <code>style</code> attribute is allowed by the configuration.
Thanks to the <a href="https://snyk.io/">Snyk Security team</a> for the
disclosure and to <a href="https://dylan.is/">Dylan Armstrong</a> for
the fix.</li>
</ul>
<h2>2.12.0 (2024-02-21)</h2>
<ul>
<li>
<p>Introduced the <code>allowedEmptyAttributes</code> option, enabling
explicit specification of empty string values for select attributes,
with the default attribute set to <code>alt</code>. Thanks to <a
href="https://github.com/zhna123">Na</a> for the contribution.</p>
</li>
<li>
<p>Clarified the use of SVGs with a new test and changes to
documentation. Thanks to <a href="https://github.com/gkumar9891">Gauav
Kumar</a> for the contribution.</p>
</li>
<li>
<p>Do not process source maps when processing style tags with
PostCSS.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/4a7d7dd099b41c909f2faac056d34cf027515079"><code>4a7d7dd</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/654">#654</a>
from apostrophecms/release-2.12.1</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/f8e02be9fc3ea639edccfcaa50c6e71a22b2c068"><code>f8e02be</code></a>
release 2.12.1</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/c5dbdf77fe8b836d3bf4554ea39edb45281ec0b4"><code>c5dbdf7</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/650">#650</a>
from dylanarmstrong/fix/ignore-source-maps</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/5a5a74e179ef98075a0c61789f64e009f6b4ac29"><code>5a5a74e</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/652">#652</a>
from apostrophecms/add-thanks-to-changelog</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/ee71ff0c04b2e00f730b8e29206cd65209cca5c4"><code>ee71ff0</code></a>
Add community contribution thanks you</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/a226fe7af4c3a8faee6d114984da3f2964e4ae65"><code>a226fe7</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/651">#651</a>
from apostrophecms/release-2.12.0</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/ff18600f01a390c81c27442d6e858ec0eb4ef67e"><code>ff18600</code></a>
release 2.12.0</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/1e2294c8001ce07c89448e03289818da631795ba"><code>1e2294c</code></a>
test: added test for postcss map</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/c376501b9a066479736f0a088fba3492e7122811"><code>c376501</code></a>
doc: update changelog</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/075499d1b98c387f4200fd59972ca9b15796b51b"><code>075499d</code></a>
fix: ignore source maps when processing with postcss</li>
<li>Additional commits viewable in <a
href="https://github.com/apostrophecms/sanitize-html/compare/2.11.0...2.12.1">compare
view</a></li>
</ul>
</details>
<br />

Updates `electron` from 25.5.0 to 25.8.4
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/electron/electron/commit/415301c477b600502cf264e93318dda551288829"><code>415301c</code></a>
chore: cherry-pick 3fbd1dca6a4d from libvpx (<a
href="https://redirect.github.com/electron/electron/issues/40024">#40024</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/b4742f9f919093ce870aaca166096072e7aaf56a"><code>b4742f9</code></a>
feat: enable dark mode on GTK UIs (<a
href="https://redirect.github.com/electron/electron/issues/40009">#40009</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/5868f9ac5eeb73ccd7ff36ff8733e03d5afd1e58"><code>5868f9a</code></a>
build: fix with <code>enable_pdf_viewer = false</code> (<a
href="https://redirect.github.com/electron/electron/issues/40000">#40000</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/6e675c831e758305b20217cc99601a20a429d02d"><code>6e675c8</code></a>
chore: add deprecated <code>app.runningUnderRosettaTranslation</code> to
breaking-change...</li>
<li><a
href="https://github.com/electron/electron/commit/66432ed9fcfabea081f14b809bd398daad1db685"><code>66432ed</code></a>
fix: use generic capturer to list both screens and windows when possible
(<a
href="https://redirect.github.com/electron/electron/issues/39">#39</a>...</li>
<li><a
href="https://github.com/electron/electron/commit/0ed48378c2c5950c55b2084c3b750b9f43d6f6a4"><code>0ed4837</code></a>
chore: cherry-pick tls shutdown crash fix from upstream (<a
href="https://redirect.github.com/electron/electron/issues/39945">#39945</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/42b4744740fec97f025019cac7f9abc59bd12ac8"><code>42b4744</code></a>
docs: add a more detailed explanation to cookies.flushStore() (<a
href="https://redirect.github.com/electron/electron/issues/39905">#39905</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/04e85b4eda93bacad55d7828c7f91c9a65e3d678"><code>04e85b4</code></a>
ci: fix linux builds of forks (<a
href="https://redirect.github.com/electron/electron/issues/39941">#39941</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/e42169b7e4e67cd4bf0da689c54082d7c9af29a3"><code>e42169b</code></a>
fix: <code>app.runningUnderARM64Translation()</code> always returning
true on Windows AR...</li>
<li><a
href="https://github.com/electron/electron/commit/67b2739f44ce98aad493170fecc696f76dc12de1"><code>67b2739</code></a>
chore: cherry-pick 1 changes from Release-0-M117 (<a
href="https://redirect.github.com/electron/electron/issues/39919">#39919</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/electron/electron/compare/v25.5.0...v25.8.4">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/bmw-software-engineering/foxbox/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: portugal <[email protected]>
Bumps the npm_and_yarn group with 2 updates:
[electron](https://github.com/electron/electron) and
[sanitize-html](https://github.com/apostrophecms/sanitize-html).

Updates `electron` from 25.5.0 to 25.8.4
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/electron/electron/commit/415301c477b600502cf264e93318dda551288829"><code>415301c</code></a>
chore: cherry-pick 3fbd1dca6a4d from libvpx (<a
href="https://redirect.github.com/electron/electron/issues/40024">#40024</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/b4742f9f919093ce870aaca166096072e7aaf56a"><code>b4742f9</code></a>
feat: enable dark mode on GTK UIs (<a
href="https://redirect.github.com/electron/electron/issues/40009">#40009</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/5868f9ac5eeb73ccd7ff36ff8733e03d5afd1e58"><code>5868f9a</code></a>
build: fix with <code>enable_pdf_viewer = false</code> (<a
href="https://redirect.github.com/electron/electron/issues/40000">#40000</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/6e675c831e758305b20217cc99601a20a429d02d"><code>6e675c8</code></a>
chore: add deprecated <code>app.runningUnderRosettaTranslation</code> to
breaking-change...</li>
<li><a
href="https://github.com/electron/electron/commit/66432ed9fcfabea081f14b809bd398daad1db685"><code>66432ed</code></a>
fix: use generic capturer to list both screens and windows when possible
(<a
href="https://redirect.github.com/electron/electron/issues/39">#39</a>...</li>
<li><a
href="https://github.com/electron/electron/commit/0ed48378c2c5950c55b2084c3b750b9f43d6f6a4"><code>0ed4837</code></a>
chore: cherry-pick tls shutdown crash fix from upstream (<a
href="https://redirect.github.com/electron/electron/issues/39945">#39945</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/42b4744740fec97f025019cac7f9abc59bd12ac8"><code>42b4744</code></a>
docs: add a more detailed explanation to cookies.flushStore() (<a
href="https://redirect.github.com/electron/electron/issues/39905">#39905</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/04e85b4eda93bacad55d7828c7f91c9a65e3d678"><code>04e85b4</code></a>
ci: fix linux builds of forks (<a
href="https://redirect.github.com/electron/electron/issues/39941">#39941</a>)</li>
<li><a
href="https://github.com/electron/electron/commit/e42169b7e4e67cd4bf0da689c54082d7c9af29a3"><code>e42169b</code></a>
fix: <code>app.runningUnderARM64Translation()</code> always returning
true on Windows AR...</li>
<li><a
href="https://github.com/electron/electron/commit/67b2739f44ce98aad493170fecc696f76dc12de1"><code>67b2739</code></a>
chore: cherry-pick 1 changes from Release-0-M117 (<a
href="https://redirect.github.com/electron/electron/issues/39919">#39919</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/electron/electron/compare/v25.5.0...v25.8.4">compare
view</a></li>
</ul>
</details>
<br />

Updates `sanitize-html` from 2.11.0 to 2.12.1
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md">sanitize-html's
changelog</a>.</em></p>
<blockquote>
<h2>2.12.1 (2024-02-22)</h2>
<ul>
<li>Do not parse sourcemaps in <code>post-css</code>. This fixes a
vulnerability in which information about the existence or non-existence
of files on a server could be disclosed via properly crafted HTML input
when the <code>style</code> attribute is allowed by the configuration.
Thanks to the <a href="https://snyk.io/">Snyk Security team</a> for the
disclosure and to <a href="https://dylan.is/">Dylan Armstrong</a> for
the fix.</li>
</ul>
<h2>2.12.0 (2024-02-21)</h2>
<ul>
<li>
<p>Introduced the <code>allowedEmptyAttributes</code> option, enabling
explicit specification of empty string values for select attributes,
with the default attribute set to <code>alt</code>. Thanks to <a
href="https://github.com/zhna123">Na</a> for the contribution.</p>
</li>
<li>
<p>Clarified the use of SVGs with a new test and changes to
documentation. Thanks to <a href="https://github.com/gkumar9891">Gauav
Kumar</a> for the contribution.</p>
</li>
<li>
<p>Do not process source maps when processing style tags with
PostCSS.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/4a7d7dd099b41c909f2faac056d34cf027515079"><code>4a7d7dd</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/654">#654</a>
from apostrophecms/release-2.12.1</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/f8e02be9fc3ea639edccfcaa50c6e71a22b2c068"><code>f8e02be</code></a>
release 2.12.1</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/c5dbdf77fe8b836d3bf4554ea39edb45281ec0b4"><code>c5dbdf7</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/650">#650</a>
from dylanarmstrong/fix/ignore-source-maps</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/5a5a74e179ef98075a0c61789f64e009f6b4ac29"><code>5a5a74e</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/652">#652</a>
from apostrophecms/add-thanks-to-changelog</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/ee71ff0c04b2e00f730b8e29206cd65209cca5c4"><code>ee71ff0</code></a>
Add community contribution thanks you</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/a226fe7af4c3a8faee6d114984da3f2964e4ae65"><code>a226fe7</code></a>
Merge pull request <a
href="https://redirect.github.com/apostrophecms/sanitize-html/issues/651">#651</a>
from apostrophecms/release-2.12.0</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/ff18600f01a390c81c27442d6e858ec0eb4ef67e"><code>ff18600</code></a>
release 2.12.0</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/1e2294c8001ce07c89448e03289818da631795ba"><code>1e2294c</code></a>
test: added test for postcss map</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/c376501b9a066479736f0a088fba3492e7122811"><code>c376501</code></a>
doc: update changelog</li>
<li><a
href="https://github.com/apostrophecms/sanitize-html/commit/075499d1b98c387f4200fd59972ca9b15796b51b"><code>075499d</code></a>
fix: ignore source maps when processing with postcss</li>
<li>Additional commits viewable in <a
href="https://github.com/apostrophecms/sanitize-html/compare/2.11.0...2.12.1">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/bmw-software-engineering/foxbox/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: portugal <[email protected]>
@aneuwald-ctw aneuwald-ctw marked this pull request as ready for review July 15, 2024 15:16
@laisspportugal
Copy link
Contributor

Besides the question, that seems to be something related to javascript itself, looks good to me

Copy link
Contributor

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aneuwald-ctw aneuwald-ctw merged commit ffd5d46 into main Jul 18, 2024
8 checks passed
@aneuwald-ctw aneuwald-ctw deleted the feature/metadata-access branch July 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants