Settings API #35
Merged
Settings API #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneuwald-ctw
previously requested changes
Jul 3, 2024
There was a problem hiding this comment.
Hey @FraLab09, it seems that some CI steps failed, could you have a look on those? As I saw, it is only small stuffs, like import libraries and not use them. Thanks!
|
Can you also please add some unit tests? At the moment I think it's better to wait till all CI checks are running ok to do a better review on our side, cause the code will be probably modified. |
packages/studio-base/src/components/PanelExtensionAdapter/PanelExtensionAdapter.tsx
Outdated
Show resolved
Hide resolved
packages/studio-base/src/components/PanelExtensionAdapter/renderState.ts
Outdated
Show resolved
Hide resolved
packages/studio-base/src/providers/ExtensionCatalogProvider.tsx
Outdated
Show resolved
Hide resolved
packages/studio-base/src/providers/ExtensionCatalogProvider.tsx
Outdated
Show resolved
Hide resolved
aneuwald-ctw
requested changes
Jul 10, 2024
packages/studio-base/src/components/PanelExtensionAdapter/renderState.ts
Outdated
Show resolved
Hide resolved
|
Please also verify the remaining errors on the pipeline: https://github.com/bmw-software-engineering/lichtblick/actions/runs/10134648745/job/28054905176?pr=35#step:7:56 |
…e panel type and the message type
Use the fromSchemaName property to find the concerned topic
Add comments Rename a few variables
|
Looks good to me, thanks for your effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Description
Allow the user to link settings to message converters depending on the panel type. The settings are assigned directly in the topics part of the foxglove settings by using the fromSchemaName property set in the converter
Here's an extension to test that functionality: it basically adds a setting for the em/drivingtube/polyline topic in the 3D panel to change the shape of the displayed dots from cubes to spheres
Checklist