test: add unit tests for the Plot panel module #318

laisspportugal · 2024-12-31T11:40:38Z

This PR aims to add unit tests in order to improve code coverage.

Tests added:

Additional modifications:

Removing unreacheable return undefined
Removing unnecessary if condition on usePlotInteractionHandlers
Adding the user-event library project that is being used on Unit Tests
Moving constants, types and styles
Splitting Plot.ts into different hooks

Checklist

The web version was tested and it is running ok
The desktop version was tested and it is running ok
This change is covered by unit tests
Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

…uilders

packages/suite-base/src/panels/Plot/PlotLegend.test.tsx

…s and ChartOptions.ts

…/lichtblick into feature/plot-unit-tests

…ware-engineering/lichtblick into feature/plot-unit-tests

packages/suite-base/src/panels/Plot/hooks/useRenderer.test.ts

packages/suite-base/src/panels/Plot/hooks/useSubscriptions.test.ts

packages/suite-base/src/panels/Plot/hooks/useSubscriptions.ts

packages/suite-base/src/panels/Plot/hooks/useSubscriptions.test.ts

…/lichtblick into feature/plot-unit-tests

package.json

luluiz

I just left a message to check the import related to "user-event". But in general it sounds good and I'm approving this PR.

sonarqubecloud · 2025-01-20T15:47:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ctw-joao-luis · 2025-01-20T15:48:10Z

Goodbye Plot tests PR, you'll be deeply missed

laisspportugal added 2 commits December 30, 2024 16:11

Datum tests

af0b6ec

MathFunctions tests

e140045

laisspportugal changed the title ~~Plot module Unit tests~~ Plot Unit tests Dec 31, 2024

laisspportugal added the enhancement New feature or request label Dec 31, 2024

laisspportugal changed the title ~~Plot Unit tests~~ test: Plot Unit tests Dec 31, 2024

laisspportugal changed the title ~~test: Plot Unit tests~~ test: add unit tests for the Plot panel module Dec 31, 2024

laisspportugal added 7 commits December 31, 2024 11:55

Remove lint checker

09edb94

Undo modifications on mathFunction logic and undo creation of Basic B…

b5fdedb

…uilders

Modifying math functions

c06d58c

Update function to treat exceptions

cba2f14

Fix lint

1b2cb9a

Plot legend tests

9d31880

Adding more tests to PlotLegend

43113a4

ctw-joao-luis reviewed Jan 6, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/PlotLegend.test.tsx Outdated Show resolved Hide resolved

ctw-joao-luis and others added 16 commits January 6, 2025 12:29

restructuring of ChartRenderer file: created types.ts, EventHandler.t…

7badc63

…s and ChartOptions.ts

update imports from ChartRenderer to types.ts

e29e6ca

import fixes

3b6746f

ChartOptions and EventHandler unit tests

b15bd8a

Vertical bars test

f98f8ed

change tests

0da3e84

restructuring Plot.tsx file: created hook for MouseEvents

026a361

Merge branch 'feature/plot-unit-tests' of github.com:Lichtblick-Suite…

8c912be

…/lichtblick into feature/plot-unit-tests

Vanising tests

3efd948

Merge branch 'feature/plot-unit-tests' of https://github.com/bmw-soft…

93ff92e

…ware-engineering/lichtblick into feature/plot-unit-tests

lint

1815b73

chart renderer unit tests

fe1fc95

getElementsAtPixel unit tests

8a1b46e

updateDatasets unit tests

f0e8782

added unit test when update should return undefined

a89f682

Moving types from Verticalbars

6190801

laisspportugal requested a review from luluiz January 16, 2025 14:03

Refactoring some tests to use basicbuilder into getPixelForXValue tests

d6cd685

laisspportugal commented Jan 16, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/hooks/useRenderer.test.ts Outdated Show resolved Hide resolved

laisspportugal commented Jan 16, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/hooks/useRenderer.test.ts Outdated Show resolved Hide resolved

luluiz added 2 commits January 17, 2025 16:01

refactored unit tests of usePanning

d1f0523

unit test use panning

1d67f43

luluiz reviewed Jan 17, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/hooks/useRenderer.test.ts Outdated Show resolved Hide resolved

luluiz reviewed Jan 17, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/hooks/useSubscriptions.test.ts Outdated Show resolved Hide resolved

luluiz reviewed Jan 17, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/hooks/useSubscriptions.ts Outdated Show resolved Hide resolved

laisspportugal added 3 commits January 17, 2025 17:38

Small improvements on useRenderer test

fd09e4f

Removing unnecessary comments

80030ee

Lint fixes

fc88c3b

luluiz reviewed Jan 17, 2025

View reviewed changes

packages/suite-base/src/panels/Plot/hooks/useSubscriptions.test.ts Outdated Show resolved Hide resolved

luluiz added 5 commits January 17, 2025 21:15

improved useSubscriptions

f4c7a04

Merge branch 'feature/plot-unit-tests' of github.com:Lichtblick-Suite…

b8a4942

…/lichtblick into feature/plot-unit-tests

added unit test in useSubscriptions

d702bdf

called config properties by the original name

e01c0dd

add typing in preloadType var

169d708

luluiz reviewed Jan 20, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

luluiz previously approved these changes Jan 20, 2025

View reviewed changes

Removing unnecessary library

9d4e245

laisspportugal dismissed luluiz’s stale review via 9d4e245 January 20, 2025 15:27

luluiz previously approved these changes Jan 20, 2025

View reviewed changes

Lint fixes

0acac82

laisspportugal dismissed luluiz’s stale review via 0acac82 January 20, 2025 15:41

luluiz approved these changes Jan 20, 2025

View reviewed changes

laisspportugal merged commit 3327a25 into main Jan 20, 2025
9 checks passed

laisspportugal deleted the feature/plot-unit-tests branch January 20, 2025 15:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add unit tests for the Plot panel module #318

test: add unit tests for the Plot panel module #318

laisspportugal commented Dec 31, 2024 •

edited

Loading

luluiz left a comment

sonarqubecloud bot commented Jan 20, 2025

ctw-joao-luis commented Jan 20, 2025

test: add unit tests for the Plot panel module #318

test: add unit tests for the Plot panel module #318

Conversation

laisspportugal commented Dec 31, 2024 • edited Loading

luluiz left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 20, 2025

Quality Gate passed

ctw-joao-luis commented Jan 20, 2025

laisspportugal commented Dec 31, 2024 •

edited

Loading