New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Parameters Coding Improvements #317

Merged

luluiz merged 1 commit into main from app-parameters-coding-improvements

Dec 30, 2024

Member

luluiz commented Dec 27, 2024 •

edited

Loading

User-Facing Changes
N/A

Description
Coding improvements:

The CLIFlags type was created but was not re-used as expected.
"props" already was unstructured in some lines before, with that, I just used this structure following this good practice.

Checklist

The web version was tested and it is running ok
The desktop version was tested and it is running ok
This change is covered by unit tests
Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated


          improvements

2ec9722

Signed-off-by: Luiz Bezerra <[email protected]>

sonarqubecloud bot commented Dec 27, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

laisspportugal approved these changes

View reviewed changes

luluiz merged commit 150b401 into main

11 checks passed

luluiz deleted the app-parameters-coding-improvements branch

December 30, 2024 14:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet