-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read CLI parameters #312
Merged
Merged
Read CLI parameters #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very nice implementation, congrats on that. |
ctw-joao-luis
previously approved these changes
Dec 19, 2024
Quality Gate passedIssues Measures |
ctw-joao-luis
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Users were not allowed to use custom flags when opening Lichtblick.
Description
Introduced the
AppParameters
provider, which accepts aRecord<string, string>
input and allows other components to access these global parameters.Implemented the flow for the desktop application to read CLI parameters starting with
--
and parse them into an object if the input is valid.This mechanism is reusable, for example, to parse URL parameters from the web version and pass them to the same "agnostic" provider.
In order to test in development mode, it is just execute the command
yarn desktop:start --defaultLayout=<SOME_LAYOUT>
after serving the development server.In production, it should be done something like this:
lichtblick --layoutDefault="layout_example"
/Applications/Lichtblick.app/Contents/MacOS/Lichtblick --layoutDefault="layout_example"
C:\Users\<USER>\AppData\Local\Programs\lichtblick\Lichtblick.exe --layoutDefault="layout_example"
Checklist