Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add App.tsx unit tests to increase coverage #309

Merged
merged 22 commits into from
Dec 17, 2024
Merged

Add App.tsx unit tests to increase coverage #309

merged 22 commits into from
Dec 17, 2024

Conversation

laisspportugal
Copy link
Contributor

@laisspportugal laisspportugal commented Dec 16, 2024 •
edited
Loading

Description

Adding tests to the App.tsx file to ensure the quality of code on rendering the app and increase code coverage.

Checklist

  • This change is covered by unit tests

@laisspportugal laisspportugal added the enhancement New feature or request label Dec 16, 2024
@laisspportugal laisspportugal changed the title Feature/app tsx tests Add App.tsx unit tests to increase coverage Dec 16, 2024
@laisspportugal laisspportugal marked this pull request as ready for review December 16, 2024 17:33
aneuwald-ctw
aneuwald-ctw requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to adjust a little the test to test more cases and be more specific in each of them

packages/suite-base/src/App.test.tsx Outdated Show resolved Hide resolved
packages/suite-base/src/App.test.tsx Show resolved Hide resolved
packages/suite-base/src/App.test.tsx Show resolved Hide resolved
packages/suite-base/src/App.test.tsx Outdated Show resolved Hide resolved
packages/suite-base/src/App.test.tsx Outdated Show resolved Hide resolved
packages/suite-base/src/App.test.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@laisspportugal
Copy link
Contributor Author

@aneuwald-ctw Changes addressed.

aneuwald-ctw
aneuwald-ctw approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ended up being a great test :)

@laisspportugal laisspportugal merged commit 6b17389 into main Dec 17, 2024
11 checks passed
@laisspportugal laisspportugal deleted the feature/app-tsx-tests branch December 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneuwald-ctw aneuwald-ctw aneuwald-ctw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laisspportugal @aneuwald-ctw