-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding search bar to extensions menu #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctw-joao-luis
changed the title
Feature/extensions menu search bar
Adding search bar to extensions menu
Dec 13, 2024
ctw-joao-luis
force-pushed
the
feature/extensions-menu-search-bar
branch
from
December 13, 2024 18:13
9d2ae92
to
c820437
Compare
…blick-Suite/lichtblick into feature/extensions-menu-search-bar
…om/bmw-software-engineering/lichtblick into feature/extensions-menu-search-bar
…blick-Suite/lichtblick into feature/extensions-menu-search-bar
…blick-Suite/lichtblick into feature/extensions-menu-search-bar
Quality Gate passedIssues Measures |
aneuwald-ctw
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Adding search bar to extensions menu to facilitate user experience
Description
This PR introduces a quality-of-life (QoL) improvement by extracting the search input used for searching topics into its own reusable component. This enhancement not only facilitates reusability but also improves maintainability across the codebase.
Additionally, the related codebase has been restructured to improve readability, modularity, and testability, ensuring a better developer experience and easier future enhancements.
Extracted the search input logic into a standalone, reusable component.
This new component can now be used in other parts of the application where similar functionality is required.
Improved Testing:
Added comprehensive tests for the new reusable search input component.
Ensured all existing functionality related to topic searching remains intact and is covered by tests.
Enhanced Reusability:
Simplified future usage of the search input by providing an easy-to-integrate and well-documented component interface.
Checklist