Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding search bar to extensions menu #305

Merged
merged 31 commits into from
Dec 20, 2024

Conversation

ctw-joao-luis
Copy link
Contributor

@ctw-joao-luis ctw-joao-luis commented Dec 13, 2024

User-Facing Changes
Adding search bar to extensions menu to facilitate user experience

image

Description

This PR introduces a quality-of-life (QoL) improvement by extracting the search input used for searching topics into its own reusable component. This enhancement not only facilitates reusability but also improves maintainability across the codebase.
Additionally, the related codebase has been restructured to improve readability, modularity, and testability, ensuring a better developer experience and easier future enhancements.

  • Extracted the search input logic into a standalone, reusable component.
    This new component can now be used in other parts of the application where similar functionality is required.

  • Improved Testing:
    Added comprehensive tests for the new reusable search input component.
    Ensured all existing functionality related to topic searching remains intact and is covered by tests.

  • Enhanced Reusability:
    Simplified future usage of the search input by providing an easy-to-integrate and well-documented component interface.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

@ctw-joao-luis ctw-joao-luis changed the title Feature/extensions menu search bar Adding search bar to extensions menu Dec 13, 2024
@ctw-joao-luis ctw-joao-luis force-pushed the feature/extensions-menu-search-bar branch from 9d2ae92 to c820437 Compare December 13, 2024 18:13
…blick-Suite/lichtblick into feature/extensions-menu-search-bar
@ctw-joao-luis ctw-joao-luis added the enhancement New feature or request label Dec 16, 2024
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@aneuwald-ctw aneuwald-ctw marked this pull request as ready for review December 20, 2024 10:59
@ctw-joao-luis ctw-joao-luis merged commit 9515242 into main Dec 20, 2024
11 checks passed
@ctw-joao-luis ctw-joao-luis deleted the feature/extensions-menu-search-bar branch December 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants