Update electron to version 33 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctw-joao-luis
approved these changes
Dec 13, 2024
|
Just left a comment regarding the info that I though could be usefull on the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
N/A
Description
Update Electron version to the latest version 33
Also, Playwright had to be updated, as the versions after Electron v28 have a small incompatibility. An extra step on pipeline was created to install the new browsers needed from the new Playwright version: microsoft/playwright#28048
Also, it was changed the react-virtualized package to react-virtualized-auto-sizer, as it is an stand alone package resulting in a smaller bundle.
Checklist