Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n of the main process #237

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Woodii1998
Copy link
Contributor

@Woodii1998 Woodii1998 commented Oct 28, 2024

User-Facing Changes

fix i18n of the main process

Description
#227

  • Remove duplicate i18next dependency from suite-desktop package
  • Enable previously commented out i18n initialization code
  • Import initI18n from suite-base package

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests

@Woodii1998
Copy link
Contributor Author

Woodii1998 commented Oct 28, 2024

By the way, I completely understand that this version is aimed at English users, but I still think it's unreasonable to hide the internationalization features. The internationalization content in the original branch is a great resource, and it has no impact on subsequent development (I mean that other options for switching languages have been removed in the settings)

@luluiz
Copy link
Member

luluiz commented Nov 4, 2024

The Sonar scanning broke because PRs made from a forked repository to Lichtblick don't have access to the Sonar tokens from the Lichtblick repository. We will look for a solution for this, but for now, it's an optional step for merging PRs.

Thank you for your contribution.

@luluiz luluiz merged commit 9a57d1b into Lichtblick-Suite:main Nov 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants