Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/making-metadata-possibly-undefined #229

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

ctw-joao-luis
Copy link
Contributor

User-Facing Changes
N/A

Description
In order to guarantee extensions compatibility with Foxglove metadata can now be undefined, this way future extensions devs will get warnings if they try to access metadata property.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests

Copy link

@ctw-joao-luis ctw-joao-luis merged commit 663914b into main Oct 18, 2024
10 checks passed
@ctw-joao-luis ctw-joao-luis deleted the fix/making-metadata-possibly-undefined branch October 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants