Removed integration-test folders from scanning #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luiz Bezerra <[email protected]>
luluiz
changed the title
Signed-off-by: Luiz Bezerra <[email protected]>
Signed-off-by: Luiz Bezerra <[email protected]>
|
aneuwald-ctw
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
N/A
Description
Removed integration tests from Sonar scanning.
Why not include E2E and integration tests in SonarQube:
Focus on production code: SonarQube is primarily designed to check the quality of production code (not test code). It focuses on static analysis, security, and code coverage metrics in unit tests, which are more precise in testing the internal logic of the code.
Unit test coverage is more relevant: Code coverage is a key metric to ensure that the production code has been well-tested in smaller units, which is the focus of quality analysis. E2E and integration tests can involve multiple layers of the application, which dilutes the granularity of the coverage.
Unnecessary noise in metrics: Including E2E and integration tests can artificially inflate the code coverage metric, as these tests tend to cover large portions of the code but do not provide the same accuracy as unit tests. This can lead to less clear reports.
Complexity in reports: E2E and integration tests may include many irrelevant details for code quality analysis, which can complicate the interpretation of SonarQube results.