Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint:ci problems #16

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Fix lint:ci problems #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e0de1b
Fix lint:ci problems
aneuwald-ctw Apr 15, 2024
cb87671
Fix more lint errors on non-used-exports
aneuwald-ctw Apr 15, 2024
c08f6e5
dedupe packages
aneuwald-ctw Apr 15, 2024
7f0688e
Fix lint
aneuwald-ctw Apr 15, 2024
cf9d044
fix missing imports
aneuwald-ctw Apr 15, 2024
46afab3
fix missing imports
aneuwald-ctw Apr 15, 2024
2504c41
Fix lint:ci
aneuwald-ctw Apr 16, 2024
65c3000
remove improvement
aneuwald-ctw Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/studio-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
"@types/uuid": "9.0.7",
"@types/wicg-file-system-access": "2020.9.6",
"@uiw/react-textarea-code-editor": "3.0.2",
"async-mutex": "0.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this aditional library for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required when running yarn lint:dependencies

"babel-jest": "29.7.0",
"babel-plugin-transform-import-meta": "2.2.1",
"browserify-zlib": "0.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/studio-base/src/components/AccountSettingsSidebar/AccountInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { useConfirm } from "@foxglove/studio-base/hooks/useConfirm";

const log = Logger.getLogger(__filename);

export const AVATAR_ICON_SIZE = 42;
const AVATAR_ICON_SIZE = 42;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: why it was changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This export was never used. It is shown when using the yarn lint:unused-exports


const useStyles = makeStyles()((theme) => ({
icon: {
Expand Down
152 changes: 0 additions & 152 deletions packages/studio-base/src/components/DataSourceSidebar/EventView.tsx
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions packages/studio-base/src/components/LayoutBrowser/UnsavedChangesPrompt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,14 @@ export function useUnsavedChangesPrompt(): {
const [isOnline, setIsOnline] = useState(layoutManager.isOnline);

useLayoutEffect(() => {
const onlineListener = () => { setIsOnline(layoutManager.isOnline); };
const onlineListener = () => {
setIsOnline(layoutManager.isOnline);
};
onlineListener();
layoutManager.on("onlinechange", onlineListener);
return () => { layoutManager.off("onlinechange", onlineListener); };
return () => {
layoutManager.off("onlinechange", onlineListener);
};
}, [layoutManager]);

const unsavedChangesPrompt = useMemo(() => {
Expand Down
185 changes: 0 additions & 185 deletions packages/studio-base/src/components/Sidebars/Sidebar.stories.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading