Skip to content

Commit

Permalink
Replace yarn constraints with dependabot grouped version updates (#6360)
Browse files Browse the repository at this point in the history
**User-Facing Changes**
None

**Description**
Use Dependabot's new native version groups feature (see
dependabot/dependabot-core#1296,
https://github.blog/changelog/2023-06-30-grouped-version-updates-for-dependabot-public-beta/)
instead of yarn constraints.

We no longer need to exclude packages such as
`@storybook/testing-library` because dependabot does not require all
versions within a group to be the same (which was a limitation of the
yarn constraints-based approach). Instead it just ensures all
dependencies are updated in one PR.
  • Loading branch information
jtbandes authored Jul 5, 2023
1 parent 8358c77 commit 52cc01e
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 84 deletions.
31 changes: 31 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,37 @@ updates:
open-pull-requests-limit: 10
labels: [] # disable default labels

# Define groups of dependencies to be updated together
# https://github.blog/changelog/2023-06-30-grouped-version-updates-for-dependabot-public-beta/
groups:
storybook:
patterns:
- "storybook"
- "@storybook/*"
eslint:
patterns:
- "@typescript-eslint/*"
emotion:
patterns:
- "@emotion/*"
electron:
patterns:
- "electron"
- "electron-*"
- "app-builder-lib"
- "builder-util"
jest:
patterns:
- "jest"
- "jest-*"
- "babel-jest"
- "@types/jest"
webpack:
patterns:
- "webpack"
- "webpack-cli"
- "webpack-dev-server"

- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
command: |
# lint steps
set -x
yarn constraints
yarn license-check
yarn dedupe --check
yarn run tsc --noEmit # typecheck files that are not included by webpack or package builds
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/dependabot-fix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: ${{ runner.os }}-yarn-

- run: yarn constraints --fix
- run: yarn install --mode skip-build
env:
# yarn runs in immutable mode "by default" in CI -- turning this off requires an
Expand Down
3 changes: 0 additions & 3 deletions .yarn/plugins/@yarnpkg/plugin-constraints.cjs

This file was deleted.

2 changes: 0 additions & 2 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,5 @@ plugins:
spec: "@yarnpkg/plugin-version"
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
spec: "@yarnpkg/plugin-workspace-tools"
- path: .yarn/plugins/@yarnpkg/plugin-constraints.cjs
spec: "@yarnpkg/plugin-constraints"

yarnPath: .yarn/yarn-wrapper.js
77 changes: 0 additions & 77 deletions constraints.pro

This file was deleted.

0 comments on commit 52cc01e

Please sign in to comment.