Skip to content

Commit

Permalink
[FIX] Fix icon resolution and separate build tasks (#168)
Browse files Browse the repository at this point in the history
**User-Facing Changes**
Build linuxn version was failing.

**Description**
The problem was the resolution of the icons. It was 588x588 and for ICNS
should be standard as 128x128, 256x256, 512x512 etc.

**Checklist**

- [x] The web version was tested and it is running ok
- [x] The desktop version was tested and it is running ok
- [x] I've updated/created the storybook file(s)
  • Loading branch information
aneuwald-ctw authored Sep 2, 2024
1 parent 275d660 commit 042a21e
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ jobs:
run: |
yarn run desktop:build:prod
- name: Build release binaries for multiple OS
run: |
yarn run package:win
yarn run package:linux
yarn run package:darwin
- name: Build windows version
run: yarn run package:win

- name: Build linux version
run: yarn run package:linux

- name: Build macOS version
run: yarn run package:darwin

# Important to use [skip actions] to avoid triggering other verisoning workflows
# https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs
Expand Down
4 changes: 2 additions & 2 deletions packages/suite-desktop/resources/icon/icon.icns
Git LFS file not shown
4 changes: 2 additions & 2 deletions packages/suite-desktop/resources/icon/icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 042a21e

Please sign in to comment.