Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add instructions for build on Windows #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jdsika
Copy link
Contributor

@jdsika jdsika commented Dec 11, 2024

  • Added dependencies on Windows including installation instructions
  • Added environsment variables
  • fixed error in Doxygen

@jdsika jdsika added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 11, 2024
@jdsika
Copy link
Contributor Author

jdsika commented Dec 11, 2024

@TimmRuppert I have a fail in gTest

@TimmRuppert
Copy link
Collaborator

Looks good to me!

Could you please add a windows test build to the CI? Maybe just rename and adjust the steps (either a second job or using the gitlab matrix key) here: https://github.com/Lichtblick-Suite/asam-osi-utilities/blob/main/.github/workflows/ubuntu.yml

@jdsika
Copy link
Contributor Author

jdsika commented Dec 11, 2024

I can not get it to compile. I think it has to do with the OSI dependency...

@TimmRuppert
Copy link
Collaborator

I can not get it to compile. I think it has to do with the OSI dependency...

I do not have a build setup on Windows. I am a bit busy today but I will try to set one up for testing within the next days. But I might not be a big help, as I have no experience in configuring complex build chains in windows.

@jdsika
Copy link
Contributor Author

jdsika commented Dec 11, 2024

BTW: Maybe this is useful? https://github.com/olympus-robotics/mcap_builder

@jdsika
Copy link
Contributor Author

jdsika commented Dec 11, 2024

I can not get it to compile. I think it has to do with the OSI dependency...

I do not have a build setup on Windows. I am a bit busy today but I will try to set one up for testing within the next days. But I might not be a big help, as I have no experience in configuring complex build chains in windows.

I think it is connected to the parsing of the version:

  Running cpp protocol buffer compiler on C:/repositories/asam-osi-utilities/build/_deps/open_simul
  ation_interface-build/osi_version.proto
  Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch.

@TimmRuppert
Copy link
Collaborator

I think it is connected to the parsing of the version:

Grasping straws here, but have you tried to compile osi outside of this project using the official instructions?

Concerning 975b98b: I am definitely no Windows expert but using Visual Studio requires project files etc.? I just read that the internal cmake support for visual studio got better but it might still be a good overhead, additional complexity and might be challening to transform ?

BTW: Maybe this is useful? https://github.com/olympus-robotics/mcap_builder

I have used this once but then saw no benefit in including this as a submodule vs. including mcap directly.

@jdsika
Copy link
Contributor Author

jdsika commented Dec 12, 2024

If I fail with MSVC I will retry with MinGw. I am using cmake and that creates the project files automatically. The build tools are allowed to be used in open source projects


```bash
> choco install git
> choco install cmake
> choco install pkgconfiglite
>
> vcpkg install protobuf[zlib] protobuf[zlib]:x64-windows
> vcpkg install --triplet=x64-windows-static-md protobuf
> vcpkg install lz4
> vcpkg install zstd
> vcpkg install gtest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gtest really needed via vcpkg. Shouldn't the FetchContent_MakeAvailable be sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants