-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add instructions for build on Windows #8
base: main
Are you sure you want to change the base?
Conversation
jdsika
commented
Dec 11, 2024
- Added dependencies on Windows including installation instructions
- Added environsment variables
- fixed error in Doxygen
Signed-off-by: jdsika <[email protected]>
@TimmRuppert I have a fail in gTest |
Signed-off-by: jdsika <[email protected]>
Looks good to me! Could you please add a windows test build to the CI? Maybe just rename and adjust the steps (either a second job or using the gitlab matrix key) here: https://github.com/Lichtblick-Suite/asam-osi-utilities/blob/main/.github/workflows/ubuntu.yml |
I can not get it to compile. I think it has to do with the OSI dependency... |
I do not have a build setup on Windows. I am a bit busy today but I will try to set one up for testing within the next days. But I might not be a big help, as I have no experience in configuring complex build chains in windows. |
Signed-off-by: jdsika <[email protected]>
BTW: Maybe this is useful? https://github.com/olympus-robotics/mcap_builder |
I think it is connected to the parsing of the version:
|
Grasping straws here, but have you tried to compile osi outside of this project using the official instructions? Concerning 975b98b: I am definitely no Windows expert but using Visual Studio requires project files etc.? I just read that the internal cmake support for visual studio got better but it might still be a good overhead, additional complexity and might be challening to transform ?
I have used this once but then saw no benefit in including this as a submodule vs. including mcap directly. |
If I fail with MSVC I will retry with MinGw. I am using cmake and that creates the project files automatically. The build tools are allowed to be used in open source projects |
Signed-off-by: jdsika <[email protected]>
|
||
```bash | ||
> choco install git | ||
> choco install cmake | ||
> choco install pkgconfiglite | ||
> | ||
> vcpkg install protobuf[zlib] protobuf[zlib]:x64-windows | ||
> vcpkg install --triplet=x64-windows-static-md protobuf | ||
> vcpkg install lz4 | ||
> vcpkg install zstd | ||
> vcpkg install gtest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is gtest really needed via vcpkg. Shouldn't the FetchContent_MakeAvailable be sufficient?