Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort person edit people list by face count #186

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jcalado
Copy link
Contributor

@jcalado jcalado commented May 8, 2023

Should fix #765.

Also added a cursor: pointer style to improve UX.

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jcalado
Copy link
Contributor Author

jcalado commented May 8, 2023

I might have misread the original issue 🤦
This improves the ModalPersonEdit modal when tagging photos from the lightbox sidebar.

EDIT: I should stop typing now. It's the same component, so this improves it everywhere.

@Nerodacles
Copy link
Contributor

Excellent! But still, I don't like the design where it's sorted by the number of faces a person has. I prefer it how it was before, sorted alphabetically. It would be better if there was a section in the settings to decide whether to sort it alphabetically or by the number of faces a person has.

@loulou91
Copy link
Contributor

loulou91 commented May 9, 2023

Please keep alphabetic order by default but add sorting by number of faces as additional capability ! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In faces tab have the posibility to sort by more photos that match faces
3 participants