This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Refactoring code to follow MVVM #4
Draft
warmachinesocial
wants to merge
21
commits into
LibrePass:main
Choose a base branch
from
warmachinesocial:refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for running and testing out At this stage, we can now begin to add env variable for dev and prod environment.
… the issue of dismiss view due to conflicts of keywords
However other changes of network monitor still left to do, at this stage just called them to make it work and build the project
Currently the code was not following MVVM and yet other changes left.
Refactored ContentView as the root (Welcome Screen), plus added signupview UI and left with loginView. AuthViewModel logic left yet to code but saving the progress
Removed the welcome screen part
At this stage, added the logic to call the rest endpoints for register, preLogin and oauth and save the key into keychain. However, left with saving the credentials into db using swiftData
At this stage we could you use to login via local authentication into the app, though a small issue is left on how to store the credentials. The functionality is working...
…ontributing to project
Also added macos support however still need to fix the UI for it but starting small steps
This reverts commit c4e697e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this stage making a draft pr, and learning on refactoring out the code.