Add email field in login cipher

LibrePass · Apr 9, 2024 · a787758 · a787758
1 parent 8104646
commit a787758
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/app/src/main/java/dev/medzik/librepass/android/ui/components/CipherCard.kt b/app/src/main/java/dev/medzik/librepass/android/ui/components/CipherCard.kt
@@ -15,7 +15,6 @@ import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.automirrored.filled.Notes
 import androidx.compose.material.icons.filled.CreditCard
 import androidx.compose.material.icons.filled.MoreHoriz
-import androidx.compose.material.icons.filled.Notes
 import androidx.compose.material.icons.filled.Person
 import androidx.compose.material3.Card
 import androidx.compose.material3.Icon
@@ -101,7 +100,12 @@ fun CipherCard(
         when (cipher.type) {
             CipherType.Login -> {
                 title = cipher.loginData!!.name
-                subtitle = cipher.loginData!!.username
+
+                if (!cipher.loginData!!.email.isNullOrEmpty()) {
+                    subtitle = cipher.loginData!!.email
+                } else if (!cipher.loginData!!.username.isNullOrEmpty()) {
+                    subtitle = cipher.loginData!!.username
+                }
             }
             CipherType.SecureNote -> {
                 title = cipher.secureNoteData!!.title

diff --git a/app/src/main/java/dev/medzik/librepass/android/ui/components/CipherEditFields.kt b/app/src/main/java/dev/medzik/librepass/android/ui/components/CipherEditFields.kt
@@ -79,6 +79,16 @@ fun CipherEditFieldsLogin(
         modifier = Modifier.padding(top = 8.dp)
     )
 
+    TextInputFieldBase(
+        label = stringResource(R.string.Email),
+        modifier =
+            Modifier
+                .fillMaxWidth()
+                .padding(vertical = 4.dp),
+        value = cipherData.email,
+        onValueChange = { cipherData = cipherData.copy(email = it) }
+    )
+
     TextInputFieldBase(
         label = stringResource(R.string.Username),
         modifier =

diff --git a/app/src/main/java/dev/medzik/librepass/android/ui/screens/vault/CipherView.kt b/app/src/main/java/dev/medzik/librepass/android/ui/screens/vault/CipherView.kt
@@ -113,12 +113,21 @@ fun CipherViewScreen(
             value = cipherData.name
         )
 
-        if (!cipherData.username.isNullOrEmpty() || !cipherData.password.isNullOrEmpty()) {
+        if (!cipherData.email.isNullOrEmpty() ||
+            !cipherData.username.isNullOrEmpty() ||
+            !cipherData.password.isNullOrEmpty()
+        ) {
             SecondaryText(
                 stringResource(R.string.LoginDetails),
                 modifier = Modifier.padding(top = 8.dp)
             )
 
+            CipherField(
+                title = stringResource(R.string.Email),
+                value = cipherData.email,
+                copy = true
+            )
+
             CipherField(
                 title = stringResource(R.string.Username),
                 value = cipherData.username,