Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors: Add support for screw terminals #96

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

dbrgn
Copy link
Member

@dbrgn dbrgn commented Jul 16, 2022

Library PR: LibrePCB-Libraries/LibrePCB_Connectors.lplib#13

Add screw terminal symbols / components.

For inspiration, I looked at the KiCAD symbol:

screenshot-20220716-221300

This looks quite nice, but we cannot replicate it because the pin labels are not yet movable.

This leaves us with two options:

A: Move the screw circle to the right, re-using the line

screenshot-20220716-224852

The circle is very small though and does not really resemble a screw.

B: Make the symbol wider

screenshot-20220716-224701

By making the symbol wider, we have room for the screw on the left side.

I chose this approach. To ensure consistent alignment with other pin headers/sockets, the rectangle expands to the left, it is not centered. This means that you can replace a pin socket with a screw terminal without the wires moving in the schematic.

Here's the final symbol:

screenshot-20220716-232200 screenshot-20220716-232240

@dbrgn dbrgn added the enhancement New feature or request label Jul 16, 2022
@dbrgn dbrgn requested review from rnestler and ubruhin July 16, 2022 21:23
@dbrgn dbrgn self-assigned this Jul 16, 2022
@ubruhin
Copy link
Member

ubruhin commented Jul 30, 2022

Nice! But why not simply make the line shorter?

image

Then the outline is the same as for the other connectors. And with LibrePCB 0.2 we could then either move the text very slightly to the right or out of the symbol to improve the look a bit (although I'm not sure about moving it of the symbol since then it would be inconsistent to all the other symbols...)

@dbrgn
Copy link
Member Author

dbrgn commented Sep 29, 2022

Hmm, I think that should work as well. I'll try to fix it.

By the way, any preferences regarding terminology, screw terminal vs terminal block?

@ubruhin
Copy link
Member

ubruhin commented Feb 15, 2024

I rebased the branch and slightly adjusted the symbol layout, now making use of the LibrePCB 1.0 feature of specifying a custom pin text position 💪

image

From my point of view, this is now ready to merge.

@dbrgn
Copy link
Member Author

dbrgn commented Feb 15, 2024

Awesome, looking great now! I'll check it again, and will then update the associated library PR.

@dbrgn dbrgn merged commit 3e4398a into master Feb 15, 2024
8 checks passed
@dbrgn dbrgn deleted the screw-terminals branch February 15, 2024 20:02
@dbrgn dbrgn mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants