Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO: Fix warnings & generate 3D models #134

Merged
merged 2 commits into from
Jul 9, 2024
Merged

DO: Fix warnings & generate 3D models #134

merged 2 commits into from
Jul 9, 2024

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Jun 23, 2024

Fix library check warnings:

  • Specify assembly type
  • Specify pad functions
  • Add package outline polygon

Generate 3D models, for both the polarized and non-polarized packages:

image

@ubruhin
Copy link
Member Author

ubruhin commented Jun 23, 2024

Hmm CI is broken, probably caused by the fact that it installs now numpy 2.0.0 while the last successful CI run was with numpy 1.xx (depending on Python version). Numpy seems to be an indirect dependency of CadQuery:

Collecting numpy>=1.20.0 (from nptyping==2.0.1->cadquery==2.3.1->librepcb-parts-generator==0.1.0)

@rnestler @dbrgn any suggestion how to fix this? Adding numpy<2 as a dependency? And can we pin all dependency versions?

@dbrgn
Copy link
Member

dbrgn commented Jun 23, 2024

I think you could just add it to the dependencies in pyproject.toml, but don't have a lot of experience with that format yet... Maybe @rnestler knows more.

ubruhin added 2 commits June 24, 2024 14:24
- Specify assembly type
- Specify pad functions
- Add package outline polygon
@ubruhin
Copy link
Member Author

ubruhin commented Jun 24, 2024

Rebased (fixes CI) and library PR opened: LibrePCB-Libraries/LibrePCB_Base.lplib#139

So it should be ready now.

@ubruhin
Copy link
Member Author

ubruhin commented Jul 9, 2024

Library PR merged, thus also merging this.

@ubruhin ubruhin merged commit 4dd71a9 into master Jul 9, 2024
8 checks passed
@ubruhin ubruhin deleted the 3d-smt-diodes branch July 9, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants