Always use Unix-style line endings in generator output #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
requested changes
Jun 2, 2024
|
@dbrgn Thanks for the review, I implemented your feedback!
Yes, I forgot to mention that but I did run the tests on my Windows machine before applying the changes in this PR and they failed, but passed once I applied the changes 👍 I updated the initial PR description to make it more clear upfront 😄 |
rnestler
approved these changes
Jun 7, 2024
dbrgn
approved these changes
Jun 8, 2024
|
Thanks for merging 🎉 @rnestler more coverage never hurts IMO 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
serialize()implementation.I think this one made sense since it was the same for
Device,Symbol,PackageandComponent. If these implementations differ in the future we could remove it again, but for now it prevents some code duplication. (I wasn't sure how to name it and where to put it, I opted forserialize_commonand put it in the outercommon.pyfile, suggestions welcome)I tried the
librepcb-cli open-library --all --strict --check --minify-step .command before the changes in this PR and it gave me the "Non-canonical file". After applying the changes in this PR it seemed to work just fine! :-)Edit: I verified the Tests on my Windows machine. They failed before applying the changes, but passed after applying the changes from this PR.