Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JST SH: Add MPNs with 'suction cap' attribute and 'JST ' dev prefix #131

Merged
merged 2 commits into from
May 31, 2024
Merged

JST SH: Add MPNs with 'suction cap' attribute and 'JST ' dev prefix #131

merged 2 commits into from
May 31, 2024

Conversation

nbes4
Copy link
Contributor

@nbes4 nbes4 commented May 30, 2024

This PR adds:

  • MPNs for the BM variants that have a 'suction cap', indicated by an appended 'T' to the non-'suction cap' MPN
  • A StringAttribute FEATURES 'Suction Cap' for the new MPNs
    grafik
  • Prefix all devices with 'JST ' (mind the whitespace)
    grafik

Discussions about the changes:
#127 (comment) ('suction cap' MPNs)
LibrePCB-Libraries/JST.lplib#5 (comment) (JST prefix)

@nbes4 nbes4 marked this pull request as ready for review May 30, 2024 16:56
ubruhin
ubruhin requested changes May 30, 2024
View reviewed changes
Copy link
Member

@ubruhin ubruhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 Just two comments, see below.

generate_jst_sh_connectors.py Outdated Show resolved Hide resolved
generate_jst_sh_connectors.py Show resolved Hide resolved
@nbes4
Copy link
Contributor Author

nbes4 commented May 30, 2024

Thanks for the swift review, I implemented your feedback!

@ubruhin
Copy link
Member

ubruhin commented May 30, 2024

Alright, I'd say this looks good now! 💪

Could you open the corresponding PR on the library repository?

@nbes4 nbes4 mentioned this pull request May 30, 2024
Merged
6 tasks
@nbes4
Copy link
Contributor Author

nbes4 commented May 30, 2024

Done, there you go LibrePCB-Libraries/JST.lplib#6 🚀

@ubruhin
Copy link
Member

ubruhin commented May 31, 2024

Library PR merged 💪 Thank you!

@ubruhin ubruhin merged commit b35912d into LibrePCB:master May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubruhin ubruhin ubruhin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbes4 @ubruhin