Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ATmega4809 #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add ATmega4809 #13

wants to merge 13 commits into from

Conversation

doom-fr
Copy link

@doom-fr doom-fr commented May 31, 2020

SUMMARY

Add ATmmega4809 device

OPEN QUESTIONS / UNRESOLVED ISSUES
CHECKLIST
  • I have read and followed the library conventions.
  • For packages, I followed IPC7351C (see details in library conventions).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License, allowing everyone to use and modify the content without any restrictions.

doom-fr and others added 11 commits October 7, 2019 20:24
@doom-fr
add ATmega324PB in TQFP package
599a163
@doom-fr
add ATmega324PB in TQFP package
1d65414
@doom-fr
add ATmega324PB in TQFP package and fix flash size ATtiny85
4ac76f8
@doom-fr
add ATmega328PB in TQFP package and 48/88/168 memory variation
7e2ec4a
@doom-fr @ubruhin
Update cmpcat/a1a5cd04-cfcc-47da-841c-d0cf666fe417/component_category.lp
eb9b1c1 
Co-Authored-By: U. Bruhin <[email protected]>
@doom-fr
change physical symbols of ATmegaxxx-AU to quad rows symbols
2dc8a8f
@doom-fr
Merge branch 'add-ATmega324PB-ATmega328PB' of https://github.com/doom…
e5e80e8 
…-fr/Microchip.lplib into add-ATmega324PB-ATmega328PB
@doom-fr
manually change lib format version from 0.2.1 to 0.1.5
c7c3aec
@doom-fr
Change format version from 0.2 to 0.1 in .librepcb-* files
b28c735
@doom-fr
Merge branch 'add-ATmega324PB-ATmega328PB' of https://github.com/doom…
c327388 
…-fr/Microchip.lplib into add-ATmega324PB-ATmega328PB
@doom-fr
manually change version format to 0.1 in .librepcb-lib file
1bd8c52
@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Jun 1, 2020
dbrgn
dbrgn requested changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@dbrgn dbrgn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you have changed the file permissions of many pre-existing files (like the README) from 644 to 755. Can you undo that change before we carry on with the review? (Let me know if you need help with that...)

@dbrgn dbrgn added needs corrections Pull request needs corrections before next review. and removed ready for review Waiting for review by maintainers. labels Oct 1, 2020
@doom-fr
Copy link
Author

doom-fr commented Oct 4, 2020

Do not remember this change.
What should be rights ? All files and folders to 644 ? Only files ?

@dbrgn
Copy link
Collaborator

dbrgn commented Oct 4, 2020

Files should probably have 644 as permission. Folders need 755, but they aren't tracked by git, so it doesn't matter.

@doom-fr
Copy link
Author

doom-fr commented Oct 4, 2020

Done !

@dbrgn dbrgn added ready for review Waiting for review by maintainers. and removed needs corrections Pull request needs corrections before next review. labels Oct 4, 2020
@doom-fr
Copy link
Author

doom-fr commented Jan 30, 2021

Hi @dbrgn can you check this ?
I need to update this lib today and as I am not comfortable with git, I think it will be easier if you merge this pull request before.

@doom-fr doom-fr requested a review from dbrgn January 31, 2021 22:54
@dbrgn
Copy link
Collaborator

dbrgn commented Jan 31, 2021

I'll try to take a look at this in the coming week, if I find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrgn dbrgn Awaiting requested review from dbrgn

Assignees
No one assigned
Labels
addition New library element. ready for review Waiting for review by maintainers.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doom-fr @dbrgn @ubruhin