Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay coil/solenoid symbol - change pin text alignment #148

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

DoppioT
Copy link
Contributor

@DoppioT DoppioT commented Nov 21, 2024

SUMMARY

Change the alignment of the text on pins of a Relay Coil/Solenoid symbol

When the relay coil is used in a 2-coil relay, in which the pins are called Set+/- Rst+/-, the text of the two pins overlaps
image

This PR changes the pin text offset from left-center to center-bottom
image

This of course also impacts the 1-coil relay, but I'd say that the component remains readable, IMHO
Before:
image
After:
image

DATASHEETS / REFERENCES

N/A

OPEN QUESTIONS / UNRESOLVED ISSUES

In the 2-coil relay, the pin text now slightly overlap with the border. It seems still preferable to left-center alignment which causes the + and - signs in the 1-coil relay to be far from their pin
image

CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions). (didn't change)
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@ubruhin
Copy link
Contributor

ubruhin commented Nov 21, 2024

Hi,
thanks for pointing out this problem.
Wouldn't it look even better if rotating the texts by 90° so they can stay centered?

@DoppioT
Copy link
Contributor Author

DoppioT commented Nov 21, 2024

Wouldn't it look even better if rotating the texts by 90° so they can stay centered?

You're right
image
image

PR updated

@ubruhin ubruhin added fix Fix an error in an existing library element. ready for review Waiting for review by maintainers. labels Nov 21, 2024
@ubruhin
Copy link
Contributor

ubruhin commented Nov 21, 2024

Perfect, thank you! 👍

@ubruhin ubruhin merged commit d409647 into LibrePCB-Libraries:master Nov 21, 2024
1 check passed
@DoppioT DoppioT deleted the relay_coil_fix branch November 22, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix an error in an existing library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants