Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normally closed jumpers and 3P3P transformer #136

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

eto-
Copy link
Contributor

@eto- eto- commented Feb 22, 2024

SUMMARY

I added:

  • normally closed jumper (for default setting) to be cut in PCB
  • a 3P3P transformer
DATASHEETS / REFERENCES
OPEN QUESTIONS / UNRESOLVED ISSUES
CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

Alessandro Razeto and others added 2 commits February 22, 2024 15:39
- Hide pin names of transformer -> consistency with 3P2P transformer
- Make jumper descriptions a bit more clear
- Approve library editor warnings
@ubruhin ubruhin self-assigned this Sep 19, 2024
@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Sep 19, 2024
@ubruhin
Copy link
Contributor

ubruhin commented Sep 19, 2024

Sorry for the late review! I checked them now and it looks quite good 🎉 I just added a few minor adjustments (see commit), hope you are fine with this.

Thanks for the contribution!

@ubruhin ubruhin changed the title Added normally closed jumpers and 3P3P transformer Add normally closed jumpers and 3P3P transformer Sep 19, 2024
@ubruhin ubruhin merged commit 50026ac into LibrePCB-Libraries:master Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants