Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sym/cmp for bridge rectifier #123

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

Recycled0080
Copy link
Contributor

SUMMARY

added sym/cmp
Screenshot from 2023-09-28 10-04-34
for bridge rectifier both EU and US

DATASHEETS / REFERENCES
OPEN QUESTIONS / UNRESOLVED ISSUES
CHECKLIST
  • [ x] I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • [ x] I already used the new library elements in a design and verified their correctness (optional).
  • [x ] I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • [ x] I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@ubruhin
Copy link
Contributor

ubruhin commented Sep 29, 2023

Very nice!

Just two ideas:

  • Could the symbols be slightly shrinked to get the pins located on a 4x4 grid instead of 6x6? I think it would help to keep schematics compact. Note that the pin length could be shortened a bit (e.g. to 1.27mm) for this purpose.
  • Probably it would look better to enable the grab area on the diode triangles, for consistency with single diodes?

@ubruhin ubruhin added addition New library element. needs corrections Pull request needs corrections before next review. labels Sep 29, 2023
@ubruhin ubruhin changed the title Bridge Rectifier sym/cmp Add sym/cmp for bridge rectifier Sep 29, 2023
@Recycled0080
Copy link
Contributor Author

I have shrunk the symbols down to 4x4, I added extra grab areas to triangles, picture below,
Screenshot from 2023-10-02 12-41-38
Screenshot from 2023-10-02 11-54-29

@ubruhin
Copy link
Contributor

ubruhin commented Oct 2, 2023

The 4x4 looks great IMO 👍 Regarding the grab area, maybe I was not clear enough, sorry. I meant to enable the "Grab Area" property of the already existing triangle polygons so the diodes are filled with yellow color the same way as single diodes. I quickly changed this by myself now (and also moved text labels in the EU symbol to the same position as in the US symbol):

image

Thanks for this contribution! 🎉

@ubruhin ubruhin added ready for review Waiting for review by maintainers. and removed needs corrections Pull request needs corrections before next review. labels Oct 2, 2023
@ubruhin ubruhin merged commit 4ee7735 into LibrePCB-Libraries:master Oct 2, 2023
@ubruhin ubruhin mentioned this pull request Sep 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants