fix(api): API calls were broken due to abstract method #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class `ScheduleWebServiceView` had an abstract method
`BindViewableResourceReservation` which was not implemented. This
caused API access to fail with an error like:
[php:error] [pid 84] [client 10.89.0.25:59502] PHP Fatal error: Class ScheduleWebServiceView contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (ISchedulePage::BindViewableResourceReservations) in /var/www/html/WebServices/SchedulesWebService.php on line 169
Implement the missing method as a `no-op` method.
Closes: LibreBooking#343
|
I'll be honest and admit that I don't know for sure if adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
ScheduleWebServiceViewhad an abstract methodBindViewableResourceReservationwhich was not implemented. This caused API access to fail with an error like:Implement the missing method as a
no-opmethod.Closes: #343